Skip to content

lua plugin: fix for incorrectly injecting global plugin stats - #6817

Merged
randall merged 1 commit into
apache:masterfrom
traeak:lua_statbug
May 28, 2020
Merged

lua plugin: fix for incorrectly injecting global plugin stats#6817
randall merged 1 commit into
apache:masterfrom
traeak:lua_statbug

Conversation

@traeak

@traeak traeak commented May 21, 2020

Copy link
Copy Markdown
Contributor

Fixes a bug where the global lua plugin stats are incorrectly assigned causing a collision with remap plugins.

@jvgutierrez

Copy link
Copy Markdown
Member

I've tested this on top of our 8.x branch + #6802 + #4924 (to get a clean patch applied) and it solves the issues I've commented on #6802

jvgutierrez
jvgutierrez previously approved these changes May 22, 2020
@traeak

traeak commented May 22, 2020

Copy link
Copy Markdown
Contributor Author

with the autest the traffic_ctl metric match is what's causing trouble. How to ensure it runs until the metrics show up?

@shukitchan

Copy link
Copy Markdown
Contributor

It looks good. thanks.

shukitchan
shukitchan previously approved these changes May 23, 2020
@traeak
traeak dismissed stale reviews from shukitchan and jvgutierrez via f030bcb May 26, 2020 16:09
@traeak

traeak commented May 26, 2020

Copy link
Copy Markdown
Contributor Author

I hope I got it. My global lua script was an invalid global lua script. Fixing that seems to have fixed the autest.

@traeak

traeak commented May 26, 2020

Copy link
Copy Markdown
Contributor Author

[approve ci autest]

@randall

randall commented May 26, 2020

Copy link
Copy Markdown
Contributor

[approve ci autest]

@randall
randall merged commit b863c08 into apache:master May 28, 2020
@zwoop

zwoop commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

Cherry-picked to v9.0.x branch.

@zwoop zwoop modified the milestones: 10.0.0, 9.0.0 Jun 2, 2020
@traeak
traeak deleted the lua_statbug branch January 13, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants