Adjust ssl read loops for POST timeouts - #2248
Closed
shinrich wants to merge 3 commits into
Closed
Conversation
added 2 commits
July 6, 2017 21:28
Member
Author
|
Closing this PR in reference to the PR #2249 against master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking over from PR #2242. Taking @maskit and @oknet comments to break up the read loop to fill at most one buffer block before giving control back to event loop. Keeping read triggered if there is more to be read, so hopefully there will not be needless waiting (probably the cause of my original slow upload problems).
Also added logic to set inactivity timeout to 0 on UA side after the user agent has sent all of its data. Not 100% sure this is what we want to do. It did solve my reproduction case, but I think pdm's case is different. Threw it in to help debugging.
Also backed up one commit temporarily to push along debugging. That commit is not part of the final solution.