Skip to content

Fix PluginVC server connection cast - #13453

Merged
bneradt merged 1 commit into
apache:masterfrom
bneradt:fix-plugin-vc-server-cast
Jul 30, 2026
Merged

Fix PluginVC server connection cast#13453
bneradt merged 1 commit into
apache:masterfrom
bneradt:fix-plugin-vc-server-cast

Conversation

@bneradt

@bneradt bneradt commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Plugin intercepts provide a PluginVC for the server connection, but
HttpSM treats it as a UnixNetVConnection. This invalid downcast can
trigger libc++ RTTI diagnostics and is undefined behavior.

This keeps the connection at its NetVConnection base type, which
provides both TLS service lookups needed at that point.

Fixes: #8105

Plugin intercepts provide a PluginVC for the server connection, but
HttpSM treats it as a UnixNetVConnection. This invalid downcast can
trigger libc++ RTTI diagnostics and is undefined behavior.

This keeps the connection at its NetVConnection base type, which
provides both TLS service lookups needed at that point.

Fixes: apache#8105
@bneradt bneradt added this to the 11.0.0 milestone Jul 29, 2026
Copilot AI review requested due to automatic review settings July 29, 2026 23:07
@bneradt bneradt self-assigned this Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maskit
maskit requested a review from Copilot July 29, 2026 23:19

@maskit maskit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@bneradt

bneradt commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

[approve ci centos fedora]

@bneradt
bneradt merged commit 43e0b5d into apache:master Jul 30, 2026
15 checks passed
@bneradt
bneradt deleted the fix-plugin-vc-server-cast branch July 30, 2026 13:25
@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x Jul 30, 2026
cmcfarlen pushed a commit that referenced this pull request Jul 31, 2026
Plugin intercepts provide a PluginVC for the server connection, but
HttpSM treats it as a UnixNetVConnection. This invalid downcast can
trigger libc++ RTTI diagnostics and is undefined behavior.

This keeps the connection at its NetVConnection base type, which
provides both TLS service lookups needed at that point.

Fixes: #8105
(cherry picked from commit 43e0b5d)
@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x Jul 31, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 Jul 31, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor

Cherry-picked to the 10.2.x branch as e68c255 for the 10.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

dynamic_cast error 2: One or more of the following type_info's has hidden visibility...

5 participants