Skip to content

doc: clarify run-plugin argument is fixed at load time - #13429

Merged
maskit merged 1 commit into
apache:masterfrom
maskit:doc-run-plugin-static-args
Jul 29, 2026
Merged

doc: clarify run-plugin argument is fixed at load time#13429
maskit merged 1 commit into
apache:masterfrom
maskit:doc-run-plugin-static-args

Conversation

@maskit

@maskit maskit commented Jul 25, 2026

Copy link
Copy Markdown
Member

The run-plugin action's plugin-argument is parsed once when the rule loads, like a remap.config argument, and is never re-evaluated per request, so variable interpolation (e.g. %{HEADER:bar}) does not work there.

The run-plugin action's plugin-argument is parsed once when the
rule loads, like a remap.config argument, and is never
re-evaluated per request, so variable interpolation (e.g.
%{HEADER:bar}) does not work there.
@maskit
maskit requested a review from zwoop July 25, 2026 03:10
@maskit maskit self-assigned this Jul 25, 2026
Copilot AI review requested due to automatic review settings July 25, 2026 03:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies the run-plugin directive behavior in the header_rewrite admin guide by documenting that the "<plugin-argument> ..." string is parsed once at rule load/reload time (similar to remap.config) and is not re-evaluated per request, so variable interpolation does not apply.

Changes:

  • Add a documentation note under run-plugin explaining that <plugin-argument> is fixed at load/reload time.
  • Explicitly state that per-request variable interpolation (e.g. %{HEADER:bar}) does not work in run-plugin arguments.

@maskit maskit added this to the 11.0.0 milestone Jul 29, 2026
@maskit
maskit merged commit 9a847a5 into apache:master Jul 29, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x Jul 29, 2026
cmcfarlen pushed a commit that referenced this pull request Jul 31, 2026
The run-plugin action's plugin-argument is parsed once when the
rule loads, like a remap.config argument, and is never
re-evaluated per request, so variable interpolation (e.g.
%{HEADER:bar}) does not work there.

(cherry picked from commit 9a847a5)
@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x Jul 31, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 Jul 31, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor

Cherry-picked to the 10.2.x branch as a823957 for the 10.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

4 participants