Skip to content

Allow dynamic TLS record sizing - #13416

Merged
bneradt merged 1 commit into
apache:masterfrom
bneradt:allow-dynamic-tls-record-sizing
Jul 29, 2026
Merged

Allow dynamic TLS record sizing#13416
bneradt merged 1 commit into
apache:masterfrom
bneradt:allow-dynamic-tls-record-sizing

Conversation

@bneradt

@bneradt bneradt commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The documented -1 value for proxy.config.ssl.max_record_size is
incorrectly rejected by records validation, leaving dynamic TLS record
sizing unreachable from records.yaml.

This widens the accepted range to include the dynamic sentinel,
clarifies the documented modes, and extends TLS wire-level coverage to
verify the small-to-large record transition.

Fixes: #13288

Copilot AI review requested due to automatic review settings July 21, 2026 18:56
@bneradt bneradt added this to the 11.0.0 milestone Jul 21, 2026
@bneradt bneradt self-assigned this Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The documented -1 value for proxy.config.ssl.max_record_size is
incorrectly rejected by records validation, leaving dynamic TLS record
sizing unreachable from records.yaml.

This widens the accepted range to include the dynamic sentinel,
clarifies the documented modes, and extends TLS wire-level coverage to
verify the small-to-large record transition.

Fixes: apache#13288
@bneradt
bneradt force-pushed the allow-dynamic-tls-record-sizing branch from fc754e3 to 0987314 Compare July 21, 2026 19:02
Copilot AI review requested due to automatic review settings July 21, 2026 19:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bneradt
bneradt merged commit a0ece04 into apache:master Jul 29, 2026
15 checks passed
@bneradt
bneradt deleted the allow-dynamic-tls-record-sizing branch July 29, 2026 16:54
@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x Jul 29, 2026
cmcfarlen pushed a commit that referenced this pull request Jul 31, 2026
The documented -1 value for proxy.config.ssl.max_record_size is
incorrectly rejected by records validation, leaving dynamic TLS record
sizing unreachable from records.yaml.

This widens the accepted range to include the dynamic sentinel,
clarifies the documented modes, and extends TLS wire-level coverage to
verify the small-to-large record transition.

Fixes: #13288
(cherry picked from commit a0ece04)
@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x Jul 31, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 Jul 31, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor

Cherry-picked to the 10.2.x branch as 7109569 for the 10.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

proxy.config.ssl.max_record_size rejects the documented value -1 (dynamic TLS record sizing)

3 participants