Add HTTP alternate quality AuTest - #13391
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an AuTest that makes the effect of TSHttpAltInfoQualitySet() observable by validating which cached alternate is selected during cache lookup, addressing the gap described in #7205.
Changes:
- Add a dedicated AuTest plugin (
http_alt_info_quality) that assigns alternate “quality” by comparing client vs cached request query strings. - Add a new replay-driven cache test that stores multiple alternates and asserts the selected cached response via response headers.
- Wire the plugin into the AuTest build and test harness.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/tools/plugins/http_alt_info_quality.cc | New AuTest plugin that sets alternate quality based on query-string equality. |
| tests/tools/plugins/CMakeLists.txt | Builds the new AuTest plugin. |
| tests/gold_tests/cache/replay/alternate-caching-quality.yaml | New replay scenario asserting alternate creation/selection behavior. |
| tests/gold_tests/cache/alternate-caching.test.py | Runs the new replay and loads the new test plugin for the ATS process. |
bneradt
force-pushed
the
http-alt-info-quality-autest
branch
2 times, most recently
from
July 15, 2026 23:24
35c1f6a to
2ba9ee4
Compare
This adds an AuTest to verify the TSHttpAltInfoQualitySet plugin API. The test verifies alternate creation and selection through observable cached responses. Closes: apache#7205
bneradt
force-pushed
the
http-alt-info-quality-autest
branch
from
July 16, 2026 13:26
2ba9ee4 to
857eae2
Compare
moonchen
approved these changes
Jul 28, 2026
moonchen
left a comment
moonchen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this.
Contributor
|
Cherry-picked to the 10.2.x branch as a51cc7b for the 10.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an AuTest to verify the TSHttpAltInfoQualitySet plugin API.
The test verifies alternate creation and selection through observable
cached responses.
Closes: #7205