Skip to content

tls_renegotiation autest: gate the detection-line check to OpenSSL #13371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moonchen merged 1 commit into from
Jul 8, 2026
Merged

tls_renegotiation autest: gate the detection-line check to OpenSSL #13371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tests/gold_tests/tls/tls_renegotiation.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,15 @@ def _configure_trafficserver(self) -> 'Process':
# The refused renegotiation must not abort the process.
ts.Disk.traffic_out.Content = Testers.ExcludesExpression(
"received signal|failed assertion", "ATS must refuse the renegotiation without crashing")
# ...and it must actually reach the renegotiation-detection path (otherwise
# a no-crash pass could mean the client never managed to renegotiate at all).
ts.Disk.traffic_out.Content += Testers.ContainsExpression(
"trying to renegotiate from the client", "ATS must detect the client-initiated renegotiation")
# ...and, on OpenSSL, it must actually reach ATS's renegotiation-detection
# path (otherwise a no-crash pass could mean the client never managed to
# renegotiate at all). BoringSSL rejects a peer-initiated renegotiation inside
# the library before ATS's info callback runs -- SSL_get_state() there only
# ever returns SSL_ST_INIT or SSL_ST_OK, never SSL_ST_RENEGOTIATE -- so the
# detection line is never logged. The no-crash check above still covers it.
if Condition.IsOpenSSL():
ts.Disk.traffic_out.Content += Testers.ContainsExpression(
"trying to renegotiate from the client", "ATS must detect the client-initiated renegotiation")
return ts

def run(self) -> None:
Expand Down