Avoid JSONRPC client write spins - #13329
Merged
Merged
Conversation
JSONRPC clients use nonblocking Unix sockets, so a full peer receive buffer can make write return EAGAIN. The old retry loop treated that like EINTR and immediately retried forever, which could hang the jsonrpc server tests during large request and restart coverage. This waits for socket write readiness before retrying transient backpressure and reports ETIMEDOUT when the readiness wait expires, while preserving readiness poll errors. This also adds a regression test that fills a socketpair and verifies that the helper returns with that timeout signal instead of spinning.
bneradt
force-pushed
the
jsonrpc-client-write-ready
branch
from
June 25, 2026 20:30
9a0684c to
fb13f27
Compare
Contributor
|
Looks good to me! |
cmcfarlen
approved these changes
Jun 29, 2026
Contributor
Author
|
Marking as backport to 10.1.x and 10.2.x because it's annoying to have these tests fail in CI for those branches. |
Contributor
|
Cherry-picked to 10.1.x branch |
cmcfarlen
pushed a commit
that referenced
this pull request
Jul 27, 2026
JSONRPC clients use nonblocking Unix sockets, so a full peer receive buffer can make write return EAGAIN. The old retry loop treated that like EINTR and immediately retried forever, which could hang the jsonrpc server tests during large request and restart coverage. This waits for socket write readiness before retrying transient backpressure and reports ETIMEDOUT when the readiness wait expires, while preserving readiness poll errors. This also adds a regression test that fills a socketpair and verifies that the helper returns with that timeout signal instead of spinning. (cherry picked from commit 18d7a9d)
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jul 29, 2026
JSONRPC clients use nonblocking Unix sockets, so a full peer receive buffer can make write return EAGAIN. The old retry loop treated that like EINTR and immediately retried forever, which could hang the jsonrpc server tests during large request and restart coverage. This waits for socket write readiness before retrying transient backpressure and reports ETIMEDOUT when the readiness wait expires, while preserving readiness poll errors. This also adds a regression test that fills a socketpair and verifies that the helper returns with that timeout signal instead of spinning. (cherry picked from commit 18d7a9d)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
JSONRPC clients use nonblocking Unix sockets, so a full peer receive buffer can make write return EAGAIN. The old retry loop treated that like EINTR and immediately retried forever, which could hang the jsonrpc server tests during large request and restart coverage. This waits for socket write readiness before retrying transient backpressure and reports ETIMEDOUT when the readiness wait expires, while preserving readiness poll errors. This also adds a regression test that fills a socketpair and verifies that the helper returns with that timeout signal instead of spinning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSONRPC clients use nonblocking Unix sockets, so a full peer receive
buffer can make write return EAGAIN. The old retry loop treated that
like EINTR and immediately retried forever, which could hang the
jsonrpc server tests during large request and restart coverage.
This waits for socket write readiness before retrying transient
backpressure and treats an unwritable or zero-byte write as a failure.
This also adds a regression test that fills a socketpair and verifies
that the helper returns instead of spinning.