Skip to content

Fix stale_response FORCE_SIE enum - #13326

Merged
bneradt merged 1 commit into
apache:masterfrom
bneradt:issue-265-stale-response-force-sie
Jun 25, 2026
Merged

Fix stale_response FORCE_SIE enum#13326
bneradt merged 1 commit into
apache:masterfrom
bneradt:issue-265-stale-response-force-sie

Conversation

@bneradt

@bneradt bneradt commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Give the FORCE_SIE test mode its own enum value so the stale-if-error rows are not aliases of FORCE_SWR. Add a load-time guard to catch future duplicate OptionType values before the autest runs.

Give the FORCE_SIE test mode its own enum value so the stale-if-error rows are not aliases of FORCE_SWR. Add a load-time guard to catch future duplicate OptionType values before the autest runs.
@bneradt bneradt added this to the 11.0.0 milestone Jun 24, 2026
Copilot AI review requested due to automatic review settings June 24, 2026 22:35
@bneradt bneradt self-assigned this Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bneradt bneradt added Tests AuTest Plugins easy_review No new logic, easy to review. labels Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread tests/gold_tests/pluginTest/stale_response/stale_response.test.py
@bneradt
bneradt merged commit 9fe25ce into apache:master Jun 25, 2026
15 checks passed
@bneradt
bneradt deleted the issue-265-stale-response-force-sie branch June 25, 2026 01:43
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jul 29, 2026
Give the FORCE_SIE test mode its own enum value so the stale-if-error rows are not aliases of FORCE_SWR. Add a load-time guard to catch future duplicate OptionType values before the autest runs.
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jul 29, 2026
Give the FORCE_SIE test mode its own enum value so the stale-if-error rows are not aliases of FORCE_SWR. Add a load-time guard to catch future duplicate OptionType values before the autest runs.

(cherry picked from commit 9fe25ce)
@cmcfarlen cmcfarlen moved this to Picked v10.2.0 in ATS v10.2.x Jul 29, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 Jul 29, 2026
@github-project-automation github-project-automation Bot moved this from Picked v10.2.0 to For v10.2.0 in ATS v10.2.x Jul 29, 2026
@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AuTest easy_review No new logic, easy to review. Plugins Tests

Projects

Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

4 participants