Use fixture listener in test_EventSystem - #13308
Merged
JosiahWI merged 1 commit intoJun 23, 2026
Merged
Conversation
This removes the Catch2 listener from test_EventSystem.cc, using the identical listener from inkevent_test_fixtures.h instead. There is a similar listener in the IOBuffer test, but it is not an exact duplicate (it calls `LibRecordsConfigInit`).
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the test_EventSystem Catch2 unit test executable to use the shared EventProcessorListener defined in inkevent_test_fixtures.h, avoiding duplicated event system bootstrapping logic across inkevent unit tests.
Changes:
- Include
inkevent_test_fixtures.hintest_EventSystem.ccand useinkevent_test::EventProcessorListener. - Remove the locally-defined
EventProcessorListenerstruct and its now-redundant includes.
bneradt
approved these changes
Jun 23, 2026
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
This removes the Catch2 listener from test_EventSystem.cc, using the identical listener from inkevent_test_fixtures.h instead. There is a similar listener in the IOBuffer test, but it is not an exact duplicate (it calls `LibRecordsConfigInit`).
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
This removes the Catch2 listener from test_EventSystem.cc, using the identical listener from inkevent_test_fixtures.h instead. There is a similar listener in the IOBuffer test, but it is not an exact duplicate (it calls `LibRecordsConfigInit`). (cherry picked from commit bd785f4)
github-project-automation
Bot
moved this from Picked v10.2.0
to For v10.2.0
in ATS v10.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the Catch2 listener from test_EventSystem.cc, using the identical listener from inkevent_test_fixtures.h instead.
There is a similar listener in the IOBuffer test, but it is not an exact duplicate (it calls
LibRecordsConfigInit).