Fix tsapi build with ENABLE_PROBES=ON - #13276
Merged
Merged
Conversation
Cache headers transitively pull in <ts/ats_probe.h> via P_CacheDir.h. When ENABLE_PROBES=ON, ENABLE_SYSTEMTAP_PROBES is defined and ats_probe.h `#include <sys/sdt.h>`. tsapi's include path didn't have lib/systemtap, so the build failed. Mirror what tscore already does (src/tscore/CMakeLists.txt:110), gated on ENABLE_PROBES so the dependency only attaches when probes are actually enabled.
Contributor
|
This was introduced in #13245, but the root issue is including a private header file from a public one and exposing impl details. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes building the tsapi shared library when -DENABLE_PROBES=ON by ensuring tsapi gets the in-tree SystemTap SDT header include path (lib/systemtap) via the existing systemtap::systemtap interface target.
Changes:
- Conditionally link
tsapiagainstsystemtap::systemtapwhenENABLE_PROBESis enabled so<sys/sdt.h>can be found during compilation.
cmcfarlen
approved these changes
Jun 15, 2026
Contributor
|
[approve ci autest 3] |
bneradt
approved these changes
Jun 16, 2026
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
Cache headers transitively pull in <ts/ats_probe.h> via P_CacheDir.h. When ENABLE_PROBES=ON, ENABLE_SYSTEMTAP_PROBES is defined and ats_probe.h `#include <sys/sdt.h>`. tsapi's include path didn't have lib/systemtap, so the build failed. Mirror what tscore already does (src/tscore/CMakeLists.txt:110), gated on ENABLE_PROBES so the dependency only attaches when probes are actually enabled.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
Cache headers transitively pull in <ts/ats_probe.h> via P_CacheDir.h. When ENABLE_PROBES=ON, ENABLE_SYSTEMTAP_PROBES is defined and ats_probe.h `#include <sys/sdt.h>`. tsapi's include path didn't have lib/systemtap, so the build failed. Mirror what tscore already does (src/tscore/CMakeLists.txt:110), gated on ENABLE_PROBES so the dependency only attaches when probes are actually enabled. (cherry picked from commit 52a124b)
github-project-automation
Bot
moved this from Picked v10.2.0
to For v10.2.0
in ATS v10.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache headers transitively pull in <ts/ats_probe.h> via P_CacheDir.h. When ENABLE_PROBES=ON, ENABLE_SYSTEMTAP_PROBES is defined and ats_probe.h
#include <sys/sdt.h>. tsapi's include path didn't have lib/systemtap.