Fix mismatched log field types more - #13256
Merged
Merged
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the logging field type cleanup from #13223 by correcting additional LogField type declarations in Log::init_fields() so they match the actual marshal/unmarshal behavior, improving correctness for type-driven consumers (e.g., filters/aggregates and binary log readers).
Changes:
- Re-type
client_ssl_cert_provided(cscert) andproxy_ssl_cert_provided(pscert) fromSTRINGtosINTto matchmarshal_*_provided_cert()writing a single int. - Re-type
next_hop_port(nhp) fromIPtosINTto matchmarshal_next_hop_port()writing the port as an int. - Re-type
proxy_protocol_authority(ppa) fromIPtoSTRINGto matchmarshal_proxy_protocol_authority()writing a string payload.
cmcfarlen
approved these changes
Jun 15, 2026
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 16, 2026
(cherry picked from commit 36b8649)
Contributor
|
Cherry-picked to 10.1.x branch |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 25, 2026
(cherry picked from commit 36b8649)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #13223. Four more LogFields are initialized with unmatched types with marshal/unmarshal function.
Seems we're easily make mistake with this, we need something to check it at compile time.