Add TSMutex lock guard - #13188
Merged
Merged
Conversation
bneradt
added
TS API
Plugins
Enhancement
easy_review
zwoop
previously approved these changes
May 21, 2026
bneradt
force-pushed
the
tsmutex-lock-guard
branch
from
May 23, 2026 22:20
582bc8c to
ca811de
Compare
Plugin code that protects small critical sections with TSMutex has to pair every early return with a matching unlock. That pattern is easy to get wrong and makes the intended lock lifetime harder to see. This adds a small TSMutexLockGuard helper to the plugin API and uses it in plugin code where the mutex naturally stays locked until a return path.
bneradt
force-pushed
the
tsmutex-lock-guard
branch
from
June 15, 2026 23:20
ca811de to
157193e
Compare
masaori335
approved these changes
Jun 15, 2026
masaori335
left a comment
masaori335
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. No leak of lock anymore.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
Plugin code that protects small critical sections with TSMutex has to pair every early return with a matching unlock. That pattern is easy to get wrong and makes the intended lock lifetime harder to see. This adds a small TSMutexLockGuard helper to the plugin API and uses it in plugin code where the mutex naturally stays locked until a return path.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
Plugin code that protects small critical sections with TSMutex has to pair every early return with a matching unlock. That pattern is easy to get wrong and makes the intended lock lifetime harder to see. This adds a small TSMutexLockGuard helper to the plugin API and uses it in plugin code where the mutex naturally stays locked until a return path. (cherry picked from commit 094c755)
github-project-automation
Bot
moved this from Picked v10.2.0
to For v10.2.0
in ATS v10.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin code that protects small critical sections with TSMutex has to pair
every early return with a matching unlock. That pattern is easy to get wrong
and makes the intended lock lifetime harder to see.
This adds a small TSMutexLockGuard helper to the plugin API and uses it in
plugin code where the mutex naturally stays locked until a return path.