slice: fix stpcpy off-by-one for header value extraction - #13181
Merged
Conversation
The off by one wastes a single character, it doesn't overrun.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the slice plugin’s HttpHeader::valueForKey() helper to fix an off-by-one capacity check when copying a MIME header value into a caller-provided buffer, and clarifies the function’s contract in the header.
Changes:
- Fixes the copy/termination capacity check to allow using the full available buffer (while still reserving space for
'\0'). - Adds input validation for
nullptroutput parameters and rejects invalidindexvalues (< -1). - Updates the API comment to describe null-termination and caller responsibilities.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugins/slice/HttpHeader.h |
Clarifies valueForKey() output / null-termination expectations and buffer capacity responsibility. |
plugins/slice/HttpHeader.cc |
Fixes the off-by-one condition in valueForKey() and adds some argument validation / initialization behavior. |
Contributor
|
[approve ci] |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
JosiahWI
approved these changes
Jun 9, 2026
JosiahWI
left a comment
JosiahWI
left a comment
Contributor
There was a problem hiding this comment.
This simplifies the logic flow.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
* slice: fix stpcpy off-by-one for header value extraction The off by one wastes a single character, it doesn't overrun. * HttpHeader: check for pass in zero length value Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
* slice: fix stpcpy off-by-one for header value extraction The off by one wastes a single character, it doesn't overrun. * HttpHeader: check for pass in zero length value Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> (cherry picked from commit b71ea74)
github-project-automation
Bot
moved this from Picked v10.2.0
to For v10.2.0
in ATS v10.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The off by one wastes a single character, it doesn't overrun.