Add per_server.connection metrics - #12250
Merged
Merged
Conversation
bneradt
requested changes
May 20, 2025
serrislew
force-pushed
the
per_server_metrics
branch
from
June 3, 2025 05:59
a264a60 to
3fc0ae4
Compare
serrislew
commented
Jun 3, 2025
| , | ||
| {RECT_CONFIG, "proxy.config.http.per_server.connection.max", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL} | ||
| , | ||
| {RECT_CONFIG, "proxy.config.http.per_server.connection.match", RECD_STRING, "both", RECU_DYNAMIC, RR_NULL, RECC_STR, "^(?:ip|host|both|none)$", RECA_NULL} |
Contributor
Author
There was a problem hiding this comment.
The match type shows "port" but not "none". Was this intentional?
Contributor
There was a problem hiding this comment.
I think you're right that this must have been missed. Clearly port is supported, looking at the implementation's set of supported tags:
trafficserver/src/iocore/net/ConnectionTracker.cc
Lines 72 to 74 in 3fc0ae4
bneradt
approved these changes
Jun 3, 2025
Contributor
|
This PR was added to the 10.1.x branch by #12269 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add following metrics for origin server connections. Follows
connection.matchrules and appends it as a suffix in the metric nametotal_connections: countactive_connections: gauge, replaces _count when enabled to keep blocking and metrics consistentblocked_connections: count to measure the blocked connectionsconfigured with
metric_enabledandmetric_prefixAlso adds
porttoproxy.config.http.per_server.connection.matchas it is in matching