Make code buildable with AWS-LC - #11219
Merged
Merged
Conversation
Contributor
|
[approve ci] |
Member
Author
|
It's not 10.0 blocker, but I'd like to merge this before it gets conflicts. |
bryancall
approved these changes
Jun 7, 2024
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Make code buildable with AWS-LC * Add CheckOpenSSLIsAwsLc.cmake * Add cmakedefine for HAVE_SSL_GET_SHARED_CURVE * Revert an unnecessary name change * Fix a build condition for HKDF (cherry picked from commit a966bc4)
Contributor
|
This PR accidentally removed ENGINE support because the |
JosiahWI
added a commit
that referenced
this pull request
Aug 3, 2026
* Remove OpenSSL ENGINE code Commit a966bc4 (#11219) accidentally disabled OpenSSL ENGINE support entirely. Although it was unintentional, it seems clear no one is using that API by this point (no one has reported it was broken), and the API is gone in recent OpenSSL versions. This patch removes the dead logic.
cmcfarlen
pushed a commit
that referenced
this pull request
Aug 4, 2026
* Remove OpenSSL ENGINE code Commit a966bc4 (#11219) accidentally disabled OpenSSL ENGINE support entirely. Although it was unintentional, it seems clear no one is using that API by this point (no one has reported it was broken), and the API is gone in recent OpenSSL versions. This patch removes the dead logic. (cherry picked from commit e7eb77a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing is tested with AWS-LC, but it builds.