Change Regex class to use PCRE2 - #11014
Merged
Merged
Conversation
bryancall
force-pushed
the
regex_interface
branch
from
January 26, 2024 00:52
a445fb9 to
3e8ea21
Compare
bryancall
force-pushed
the
regex_interface
branch
from
February 8, 2024 22:11
35f4ca2 to
99bfe44
Compare
bryancall
marked this pull request as draft
February 8, 2024 22:13
bryancall
marked this pull request as ready for review
February 15, 2024 21:01
traeak
requested changes
Feb 27, 2024
traeak
left a comment
Contributor
There was a problem hiding this comment.
Try this patch (inspired by cripts):
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 920d15835..10913055e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -258,7 +258,8 @@ if(LibLZMA_FOUND)
endif()
find_package(PCRE REQUIRED)
-find_package(PCRE2 COMPONENTS 8BIT)
+
+pkg_check_modules(PCRE2 REQUIRED IMPORTED_TARGET libpcre2-8)
include(CheckOpenSSLIsBoringSSL)
include(CheckOpenSSLIsQuictls)
traeak
reviewed
Feb 27, 2024
traeak
reviewed
Feb 27, 2024
bryancall
force-pushed
the
regex_interface
branch
from
February 28, 2024 22:11
3c4890d to
afc99e4
Compare
Contributor
Author
|
Valgrind test |
Added more unit testing
Checking against nullptr in conditionals Moved cmake pkgconfig test to top level CMakeLists.txt
bryancall
force-pushed
the
regex_interface
branch
from
February 29, 2024 17:43
48f2545 to
1773941
Compare
Contributor
Author
|
Rebased the PR. There was a change in |
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Mar 1, 2024
(cherry picked from commit 8e1c1b9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted Regex class from PCRE to PCRE2