cmake: fix support for je/mi malloc and the mallocallocator - #10407
Merged
Conversation
cmcfarlen
force-pushed
the
cmake-malloc-allocator
branch
from
September 18, 2023 15:58
f23e44a to
70bfe0a
Compare
JosiahWI
approved these changes
Sep 18, 2023
Merged
bryancall
self-requested a review
September 18, 2023 22:22
cmcfarlen
force-pushed
the
cmake-malloc-allocator
branch
from
September 20, 2023 15:23
70bfe0a to
bd792df
Compare
JosiahWI
requested changes
Sep 21, 2023
| link_libraries(jemalloc) | ||
| link_libraries(jemalloc::jemalloc) | ||
| elseif(TS_HAS_MIMALLOC) | ||
| link_libraries(mimalloc) |
Contributor
There was a problem hiding this comment.
Suggested change
| link_libraries(mimalloc) | |
| link_libraries(mimalloc::mimalloc) |
here too
Contributor
Author
There was a problem hiding this comment.
There isn't currently a mimalloc::mimalloc target
Contributor
|
Testing malloc: |
Contributor
|
By default it looks like we enable jemalloc. I don't believe this is what we do for autotools: |
bryancall
reviewed
Sep 25, 2023
| #if __has_include(<jemalloc/jemalloc.h>) | ||
| #include <jemalloc/jemalloc.h> | ||
| #else | ||
| #include <jemalloc.h> |
Contributor
There was a problem hiding this comment.
We only need to have #include <jemalloc.h> in the code for compiling with cmake. The include directory detection add in the subdir jemalloc.
However, with autotools we need to have the #include <jemalloc/jemalloc.h>
bryancall
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10377