Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Deprecate traffic_monitor/stats#4366

Merged
ocket8888 merged 2 commits into
apache:masterfrom
mhoppa:feature/deprecate_tm_stats
Jan 31, 2020
Merged

Deprecate traffic_monitor/stats#4366
ocket8888 merged 2 commits into
apache:masterfrom
mhoppa:feature/deprecate_tm_stats

Conversation

@mhoppa

@mhoppa mhoppa commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Make request to route and make sure deprecation notice is returned and then build docs to ensure the deprecation message is correctly formatted.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@ocket8888 ocket8888 added this to the Go Rewrite milestone Jan 31, 2020
@ocket8888 ocket8888 added documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops labels Jan 31, 2020
@ocket8888 ocket8888 self-assigned this Jan 31, 2020

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual requests show deprecation notices in API response payloads, docs are accurate and build without errors or warnings.

@ocket8888

Copy link
Copy Markdown
Contributor

Need to fix conflicts before merge, though

@mhoppa

mhoppa commented Jan 31, 2020

Copy link
Copy Markdown
Contributor Author

Done

@ocket8888
ocket8888 merged commit 3f13327 into apache:master Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite /traffic_monitor/stats to Go

2 participants