This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix user current update required email#4346
Merged
mitchell852 merged 4 commits intoJan 29, 2020
Merged
Conversation
ocket8888
added
bug
mhoppa
suggested changes
Jan 28, 2020
mhoppa
left a comment
mhoppa
left a comment
Contributor
There was a problem hiding this comment.
it not handles empty strings correctly but if I send in null for the request for the email it causes a internal server error and a panic in TO
Contributor
Author
|
I think that means it would have always done that, because I didn't move a dereference... weird that wasn't caught sooner. |
mhoppa
approved these changes
Jan 29, 2020
mhoppa
left a comment
mhoppa
left a comment
Contributor
There was a problem hiding this comment.
manual testing is successful, API tests pass
16 tasks
Contributor
|
This PR does not actually affect 4.0.x -- no backport necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Adds a constraint that disallows setting the user's email address to an empty string in the PUT handler for
/user/current.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the client/api integration tests. I added a case that checks for empty string emails. Other than that, try submitting a PUT request to
/user/currentand verifying that the response indicates the error.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR