This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Deprecate & Rewrite DELETE to_extension#4333
Merged
ocket8888 merged 11 commits intoJan 29, 2020
Merged
Conversation
mhoppa
force-pushed
the
feature/rewrite_delete_to_extension
branch
from
January 29, 2020 16:33
bf28fde to
b7f7457
Compare
mhoppa
marked this pull request as ready for review
January 29, 2020 16:34
ocket8888
suggested changes
Jan 29, 2020
ocket8888
approved these changes
Jan 29, 2020
ocket8888
left a comment
Contributor
There was a problem hiding this comment.
Manual testing shows the new endpoint works identically to the old one, and matches the docs which compile without warnings or errors and look accurate and well-formed, the old endpoint displays the deprecation warning in all applicable scenarios, all unit and client/api integration tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Deprecates old route of
POST /to_extension/:id/deletewith notices in perl response and in docs and adds new routeDELETE /to_extension/:idWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make a request to
POST /to_extension/:id/deletemake sure the deprecation notice is returned, make another request toDELETE /to_extension/:idand ensure that deletes a to_extension, run the API tests.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information
Dependent on #4327