Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Deprecate & Rewrite DELETE to_extension#4333

Merged
ocket8888 merged 11 commits into
apache:masterfrom
mhoppa:feature/rewrite_delete_to_extension
Jan 29, 2020
Merged

Deprecate & Rewrite DELETE to_extension#4333
ocket8888 merged 11 commits into
apache:masterfrom
mhoppa:feature/rewrite_delete_to_extension

Conversation

@mhoppa

@mhoppa mhoppa commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Deprecates old route of POST /to_extension/:id/delete with notices in perl response and in docs and adds new route DELETE /to_extension/:id

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client
  • Traffic Ops

What is the best way to verify this PR?

Make a request to POST /to_extension/:id/delete make sure the deprecation notice is returned, make another request to DELETE /to_extension/:id and ensure that deletes a to_extension, run the API tests.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Dependent on #4327

@mitchell852 mitchell852 added documentation related to documentation Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Jan 27, 2020
@mhoppa
mhoppa force-pushed the feature/rewrite_delete_to_extension branch from bf28fde to b7f7457 Compare January 29, 2020 16:33
@mhoppa
mhoppa marked this pull request as ready for review January 29, 2020 16:34
Comment thread docs/source/api/to_extensions_id_delete.rst
Comment thread docs/source/api/to_extensions_id.rst
@ocket8888 ocket8888 self-assigned this Jan 29, 2020
@ocket8888 ocket8888 added this to the Go Rewrite milestone Jan 29, 2020

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing shows the new endpoint works identically to the old one, and matches the docs which compile without warnings or errors and look accurate and well-formed, the old endpoint displays the deprecation warning in all applicable scenarios, all unit and client/api integration tests are passing.

@ocket8888
ocket8888 merged commit 3343841 into apache:master Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite /to_extensions/{{id}}/delete to Go

3 participants