This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix atscfg not adding hdr_rw_mid files to meta cfg#4304
Merged
Conversation
rob05c
added
bug
rawlinp
approved these changes
Jan 16, 2020
rawlinp
left a comment
rawlinp
left a comment
Contributor
There was a problem hiding this comment.
All UTs pass, TO API tests pass, manually tested atstccfg against a test environment and got the expected response containing hdr_rw_mid files.
Just one small nit, but I won't hold up merging.
| } | ||
| dsNames[tc.DeliveryServiceName(*ds.XMLID)] = struct{}{} | ||
| } | ||
| } else { |
Contributor
There was a problem hiding this comment.
nit: I think if-else code is generally easier to read when the shorter block comes first (i.e. inverting the logic to if tc.CacheTypeFromString(server.Type) == tc.CacheTypeMid and moving this block up).
mitchell852
added a commit
to mitchell852/trafficcontrol
that referenced
this pull request
Jan 21, 2020
…apache#4304) * prevents line breaks in ds.remapText (UI and API) * adds test to ensure ds.remapText cannot include a line break * updated fixtures to include valid line breaks for edge/mid header rewrites, regex remap and tr request/response headers * adds period to GoDoc * no need for ng-pattern * textarea does not support pattern so switching back to ng-pattern (cherry picked from commit c025d22)
mitchell852
added a commit
to mitchell852/trafficcontrol
that referenced
this pull request
Jan 21, 2020
…apache#4304) * prevents line breaks in ds.remapText (UI and API) * adds test to ensure ds.remapText cannot include a line break * updated fixtures to include valid line breaks for edge/mid header rewrites, regex remap and tr request/response headers * adds period to GoDoc * no need for ng-pattern * textarea does not support pattern so switching back to ng-pattern (cherry picked from commit c025d22)
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Jan 21, 2020
(cherry picked from commit c389e84)
rawlinp
added a commit
that referenced
this pull request
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix atscfg not adding hdr_rw_mid files to meta cfg
Includes integration tests for TO side. ORT side doesn't have an integration test framework yet; manually tested, verified config includes hdr_rw_mid_ for all DSes in that Mid's CDN with location params.
No docs, no interface change.
No changelog, no interface change (and the bug isn't in a release).
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TO API Tests. Request
/servers/mid-hostname/configfiles/atsand verify returned meta contains hdr_rw_mid_ files. Run atstccfg for/servers/mid-hostname/configfiles/atsand verify returned meta contains hdr_rw_mid_ files.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information