Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Clarify dev setup for Traffic Portal#4287

Merged
ocket8888 merged 4 commits into
apache:masterfrom
shamrickus:master
Jan 13, 2020
Merged

Clarify dev setup for Traffic Portal#4287
ocket8888 merged 4 commits into
apache:masterfrom
shamrickus:master

Conversation

@shamrickus

@shamrickus shamrickus commented Jan 13, 2020 •
edited by ocket8888
Loading

Copy link
Copy Markdown
Member

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Documentation

What is the best way to verify this PR?

Build docs and confirm changes work

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

ocket8888
ocket8888 suggested changes Jan 13, 2020
View reviewed changes
Comment thread docs/source/development/traffic_portal.rst Outdated
Comment thread docs/source/development/traffic_portal.rst Outdated
@ocket8888 ocket8888 added documentation related to documentation improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one labels Jan 13, 2020
ocket8888
ocket8888 suggested changes Jan 13, 2020
View reviewed changes
Comment thread docs/source/development/traffic_portal.rst Outdated
ocket8888
ocket8888 approved these changes Jan 13, 2020
View reviewed changes

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly, renders fine, content appears correct and concise

@ocket8888
ocket8888 merged commit 2f4d33d into apache:master Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@ocket8888 ocket8888 ocket8888 approved these changes
@mhoppa mhoppa mhoppa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation related to documentation improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shamrickus @ocket8888 @mhoppa