This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixed wrong import order and Py3-incompatibility#4286
Merged
Conversation
ocket8888
added
bug
rawlinp
reviewed
Jan 10, 2020
rawlinp
approved these changes
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Changes the import order to be correct (
__future__first) and fixes an incompatibility with Python 3 (tested CPython versions 3.8.1 and 2.7.17).Which Traffic Control components are affected by this PR?
kickstart_create_network_line.py)No documentation because this tool is undocumented - and should (hopefully) be on its way out.
What is the best way to verify this PR?
Try to run the script with a valid network.cfg file - if you don't have one it'll crash. If you don't have one that sets
BOND_DEVICEandBOND_OPTIONSit'll crash. Probably others.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR