This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix atstccfg logging non-errors#4280
Merged
Merged
Conversation
rob05c
added
bug
alficles
approved these changes
Jan 10, 2020
alficles
left a comment
alficles
left a comment
Contributor
There was a problem hiding this comment.
Yeah. This does what it says on the tin. It's not particularly complicated. We should merge this and backport it as necessary.
rob05c
added a commit
to rob05c/trafficcontrol
that referenced
this pull request
Jan 10, 2020
(cherry picked from commit 4a91ed9)
rawlinp
pushed a commit
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes atstccfg logging errors that weren't errors.
Unit tests exist, verifying behavior of atscfg. ORT doesn't have an integration testing framework, so the atstccfg side can't have tests yet. I manually tested and verified all appropriate DSes were still present in generated files, and no incorrect errors were logged.
No changelog, no interface change.
No docs, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run ORT or atstccfg, check atstccfg logs (atstccfg is configurable; ORT puts them in /tmp/ort/), verify no spurious errors are logged, verify affected files (ssl_multicert.config and cacheurl.config) generate correctly.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information