Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: adds tr request and response header fields to steering* ds forms#4274

Merged
rawlinp merged 1 commit into
apache:masterfrom
mitchell852:issue-4271-adds-tr-req-resp-to-steering
Jan 9, 2020
Merged

TP: adds tr request and response header fields to steering* ds forms#4274
rawlinp merged 1 commit into
apache:masterfrom
mitchell852:issue-4271-adds-tr-req-resp-to-steering

Conversation

@mitchell852

@mitchell852 mitchell852 commented Jan 9, 2020

Copy link
Copy Markdown
Member

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Create or update a STEERING or CLIENT_STEERING delivery service and ensure that the TR Request / Response Headers are listed under Routing Configuration Settings.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Jan 9, 2020

@mitchell852 mitchell852 Jan 9, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly branched off another branch that has a PR that has yet to be merged. Once PR#4273 is merged. This diff should go away.

@mitchell852
mitchell852 force-pushed the issue-4271-adds-tr-req-resp-to-steering branch from bd2f4f1 to ed71d9b Compare January 9, 2020 19:18

@mhoppa mhoppa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created/updated steering DS and the tr request/response headers are now present

@rawlinp
rawlinp merged commit 607a9d6 into apache:master Jan 9, 2020
mitchell852 added a commit to mitchell852/trafficcontrol that referenced this pull request Jan 9, 2020
rawlinp pushed a commit that referenced this pull request Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TR request/response headers are missing from the STEERING* delivery service form

3 participants