Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix DSRC error response#4263

Merged
ocket8888 merged 3 commits into
apache:masterfrom
ericholguin:dsrc-resp-fix
Jan 8, 2020
Merged

Fix DSRC error response#4263
ocket8888 merged 3 commits into
apache:masterfrom
ericholguin:dsrc-resp-fix

Conversation

@ericholguin

@ericholguin ericholguin commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Create a Delivery Service
Assign a Server to Delivery Service
Make a POST request to /deliveryservice_required_capabilities using the Id of the delivery service you created and using a requiredCapability value that does not exist.

Should return:

HTTP/1.1 404 Not Found
Content-Type: application/json

{
    "alerts": [
        {
            "text": "server_capability not found",
            "level": "error"
        }
    ]
}

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@ocket8888

Copy link
Copy Markdown
Contributor

can you rebase to fix these conflicts?

@ocket8888 ocket8888 added improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops labels Jan 8, 2020

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken unit tests

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified the new, correct response, unit and API/integration tests all pass.

@ocket8888
ocket8888 merged commit 3e8e517 into apache:master Jan 8, 2020
@ericholguin
ericholguin deleted the dsrc-resp-fix branch May 10, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TO: Error response conflict in deliveryservices_required_capabilities

2 participants