This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix atstccfg to not log errors for unrelated dses#4261
Merged
Conversation
Fixes atstccfg to not log errors for any_map and steering DSes which are unrelated to the DS of the config file.
rob05c
added
bug
rawlinp
approved these changes
Jan 8, 2020
rawlinp
left a comment
rawlinp
left a comment
Contributor
There was a problem hiding this comment.
Verified it builds, UTs pass, ran it manually without this PR and observed the errors, then ran it again with this PR and verified that the errors were gone.
rob05c
added a commit
to rob05c/trafficcontrol
that referenced
this pull request
Jan 9, 2020
Fixes atstccfg to not log errors for any_map and steering DSes which are unrelated to the DS of the config file. (cherry picked from commit 5494016)
rawlinp
pushed a commit
that referenced
this pull request
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes atstccfg to not log errors for any_map and steering DSes which
are unrelated to the DS of the config file.
No tests, because the changed function makes a request to Traffic Ops, and ORT doesn't have an integration test framework yet.
No docs, no interface change.
No changelog, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Request a regex_remap_*.config config using
atstccfgfor a delivery service on a CDN which also has any_map and/or steering DSes, and verify no error is loggedatscfg.DeliveryServicesToCDNDSes got X DS with nil values! Skipping!.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information