Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

updated TP to use API 1.5 and TO perl to use 1.5#4254

Merged
mitchell852 merged 2 commits into
apache:masterfrom
mattjackson220:tpTo15
Jan 6, 2020
Merged

updated TP to use API 1.5 and TO perl to use 1.5#4254
mitchell852 merged 2 commits into
apache:masterfrom
mattjackson220:tpTo15

Conversation

@mattjackson220

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Portal

What is the best way to verify this PR?

Verify that requests from TP go to the 1.5 API and that TO perl accepts requests to the 1.5 API

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Comment thread traffic_ops/app/lib/TrafficOpsRoutes.pm Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting police are going to get you :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 wee woo 🚨

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. sorry about that

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 Traffic Ops related to Traffic Ops labels Jan 3, 2020
@mitchell852

Copy link
Copy Markdown
Member

Pretty sure this PR can NOT be merged until #4198 is merged. #4198 is the PR that introduces api 1.5 and is necessary before you can make calls to 1.5.

@ocket8888

Copy link
Copy Markdown
Contributor

IDK if that's necessarily true, TO (go) already serves 1.5 and making TO (perl) do it rounds out that support, so TP should be fine. Anything else is pinned to <= 1.4 so it won't care.

@rawlinp

rawlinp commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

IDK if that's necessarily true, TO (go) already serves 1.5 and making TO (perl) do it rounds out that support, so TP should be fine. Anything else is pinned to <= 1.4 so it won't care.

TO-Go doesn't yet serve any 1.5 routes yet

@ocket8888

ocket8888 commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

"TO-Go doesn't yet serve any 1.5 routes yet"

That's right, idk what's wrong with me.

@mitchell852
mitchell852 merged commit 0d9febf into apache:master Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants