Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: Removes the UI screens that allow CRUD of api_capabilities#4236

Merged
ocket8888 merged 1 commit into
apache:masterfrom
mitchell852:issue-4235-remove-endpoint-crud
Jan 6, 2020
Merged

TP: Removes the UI screens that allow CRUD of api_capabilities#4236
ocket8888 merged 1 commit into
apache:masterfrom
mitchell852:issue-4235-remove-endpoint-crud

Conversation

@mitchell852

@mitchell852 mitchell852 commented Dec 26, 2019

Copy link
Copy Markdown
Member

What does this PR (Pull Request) do?

Removes the ability to create, update or delete an api endpoint from the api_capability table. Doing this depends on endpoints that are to be deprecated.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

These screens were somewhat hidden in the UI as roles/capabilities has yet to implemented so you have to manually navigate to https://tp.domain.net/#!/endpoints. Ensure that the table is populated and does not include a way to edit a row or create a new row.

Also run the UI tests to ensure that TP builds and any existing functionality was not broken.

This UI functionality was never documented, therefore, there are no docs to change nor were there any UI tests to delete/change.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 tech debt rework due to choosing easy/limited solution labels Dec 26, 2019
@asf-ci

asf-ci commented Dec 26, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4976/

@mitchell852
mitchell852 force-pushed the issue-4235-remove-endpoint-crud branch from 8349db2 to 6117605 Compare December 26, 2019 22:27
@asf-ci

asf-ci commented Dec 26, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4977/

@mitchell852
mitchell852 requested a review from ocket8888 January 6, 2020 15:42

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All UI tests pass

@ocket8888

Copy link
Copy Markdown
Contributor

You've got a conflict though

…the api_capability table. Doing this depends on endpoints that are to be deprecated.
@mitchell852
mitchell852 force-pushed the issue-4235-remove-endpoint-crud branch from 6117605 to f46cbad Compare January 6, 2020 20:49
@mitchell852

Copy link
Copy Markdown
Member Author

You've got a conflict though

resolved

@ocket8888
ocket8888 merged commit 001b75d into apache:master Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants