This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TP: unregisters resize event handler when navigating away from dashboard#4233
Merged
Merged
Conversation
mitchell852
added
bug
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
mitchell852
added
low impact
mitchell852
added
the
regression bug
mhoppa
approved these changes
Jan 7, 2020
mhoppa
left a comment
mhoppa
left a comment
Contributor
There was a problem hiding this comment.
works as expected! great fix 👏
mitchell852
added a commit
to mitchell852/trafficcontrol
that referenced
this pull request
Jan 8, 2020
…pache#4233) (cherry picked from commit f91bf53)
rawlinp
pushed a commit
that referenced
this pull request
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR fixes an issue where the resize event handler attached to the window for the purpose of resizing dashboard charts is never removed. This causes errors in the browser console as the resize event continues to attempt to replot a chart that doesn't exist when you are not on the dashboard page.
No tests, docs or changelog entry.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR