Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fixed segfault in DS Request validation#4217

Merged
rawlinp merged 1 commit into
apache:masterfrom
ocket8888:ds-request-segfault-fix
Dec 16, 2019
Merged

Fixed segfault in DS Request validation#4217
rawlinp merged 1 commit into
apache:masterfrom
ocket8888:ds-request-segfault-fix

Conversation

@ocket8888

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Fixes a segfault in the validation of DS Request requests where fields are nil but are not equal to nil for typing reasons.

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run associated tests, make requests to the deliveryservices/request endpoint with e.g. an empty request object ({}) and observe that no internal server error is returned (unless SMTP isn't enabled in your environment in which case you'll need to look at the TO logs to be sure that the error is because SMTP isn't enabled and not because there was a segmentation fault).

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version medium impact impacts a significant portion of a CDN, or has the potential to do so labels Dec 16, 2019
@asf-ci

asf-ci commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4938/

@rawlinp rawlinp self-assigned this Dec 16, 2019
@rawlinp rawlinp merged commit 1df1e86 into apache:master Dec 16, 2019
@ocket8888 ocket8888 deleted the ds-request-segfault-fix branch December 16, 2019 21:25
@mitchell852 mitchell852 removed the bug something isn't working as intended label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

medium impact impacts a significant portion of a CDN, or has the potential to do so regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deliveryservices/request endpoint has Internal Server Error issues

4 participants