This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix atstccfg hosting.config including inactive DS#4214
Merged
rawlinp merged 1 commit intoDec 16, 2019
Merged
Conversation
Fixes atstccfg hosting.config generation to include inactive DSes for edges, but not mids. Matches Perl behavior. This is more important than it might appear, because a common Ops procedures is to ORT "badass" new OFFLINE servers, to get their proper config before setting them REPORTED.
rob05c
added
bug
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
rawlinp
approved these changes
Dec 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes atstccfg hosting.config generation to include inactive DSes for
edges, but not mids. Matches Perl behavior.
This is more important than it might appear, because a common Ops
procedure is to ORT "badass" new OFFLINE servers, to get their
proper config before setting them REPORTED.
No tests, because this is in the data loading and not the logic it can't reasonably be unit tested, and ORT doesn't have an integration test framework yet. I've manually tested, and verified all our production servers diff identical to the old Perl.
No docs, no interface change.
No changelog, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run ORT or
atstccfgand verify OFFLINE edges are inserted into hosting.config.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR