Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix TO to remove proxy route for Go route#4210

Merged
rawlinp merged 1 commit into
apache:masterfrom
rob05c:remove-to-proxy-route
Dec 13, 2019
Merged

Fix TO to remove proxy route for Go route#4210
rawlinp merged 1 commit into
apache:masterfrom
rob05c:remove-to-proxy-route

Conversation

@rob05c

@rob05c rob05c commented Dec 13, 2019

Copy link
Copy Markdown
Member

Removes a proxyHandler route, for an endpoint which was rewritten in
Go and has a Go route.

See https://github.com/apache/trafficcontrol/pull/2305/files

No tests, just removing a proxy, existing route has been manually tested.
No docs, no interface change.
No changelog, no interface change.

  • This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Request cdns/health route, verify matches Perl, and has x-server-name Golang header.

If this is a bug fix, what versions of Traffic Control are affected?

Not a bug fix.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rob05c rob05c added the Traffic Ops related to Traffic Ops label Dec 13, 2019
@asf-ci

asf-ci commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4930/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oy, the route ordering strikes again. I think this route was here because it otherwise gets eaten by the less specific GET /cdns/{id} route. So the new GET /cdns/health routes need to be moved up here as well.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I'll fix. Give me a bit, currently using my machine to diff configs, planning to test this when that's done.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@rob05c rob05c force-pushed the remove-to-proxy-route branch from caf4287 to 4500b32 Compare December 13, 2019 20:07
Removes a proxyHandler route, for an endpoint which was rewritten in
Go and has a Go route.
@rob05c rob05c force-pushed the remove-to-proxy-route branch from 4500b32 to f0fd1b3 Compare December 13, 2019 20:12
@rawlinp rawlinp merged commit 01803dd into apache:master Dec 13, 2019
@asf-ci

asf-ci commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4931/

@asf-ci

asf-ci commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4932/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants