Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add waits on generate keys buttons to show up in TP tests#4205

Merged
mitchell852 merged 3 commits into
apache:masterfrom
mhoppa:bug/fix_client_tests
Jan 6, 2020
Merged

Add waits on generate keys buttons to show up in TP tests#4205
mitchell852 merged 3 commits into
apache:masterfrom
mhoppa:bug/fix_client_tests

Conversation

@mhoppa

@mhoppa mhoppa commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

We are seeing TP tests Intermittently run into the error

NoSuchElementError: No element found using locator: By(css selector, *[name="{{button_name}}"])

This PR adds waits for the three tests that are having that error.

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

Run TP tests

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@asf-ci

asf-ci commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4923/

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 tests related to tests and/or testing infrastructure labels Dec 12, 2019
Comment thread traffic_portal/test/end_to_end/CDNs/cdns-spec.js Outdated
@mitchell852 mitchell852 self-assigned this Jan 6, 2020
@mitchell852
mitchell852 merged commit df7ff48 into apache:master Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants