This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add Go implementation of GET, POST federations/{id}/federation_resolvers#4191
Merged
mitchell852 merged 20 commits intoDec 30, 2019
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
lactose
force-pushed
the
dev/rewrite-federations-federation-resolvers
branch
from
December 18, 2019 17:34
ad91579 to
bd1714a
Compare
ocket8888
suggested changes
Dec 18, 2019
ocket8888
reviewed
Dec 18, 2019
ocket8888
suggested changes
Dec 19, 2019
ocket8888
reviewed
Dec 19, 2019
Member
|
@lactose - i'm seeing a couple of failing API tests: |
(cherry picked from commit 91cf59c)
…d}/federation_resolvers endpoint
lactose
force-pushed
the
dev/rewrite-federations-federation-resolvers
branch
from
December 24, 2019 23:27
426215d to
25f0e5c
Compare
Contributor
Author
|
@mitchell852 tests are now working |
Member
|
@lactose - i'm seeing a difference between the Perl's GET behavior and the Go's GET behavior: Perl: GET api/1.4/federations/1/federation_resolvers where no fed resolvers are assigned to the federation:
Go: GET api/1.4/federations/1/federation_resolvers where no fed resolvers are assigned to the federation:
The POST, however, looks fine. |
Contributor
Author
|
@mitchell852 pushed an update |
mitchell852
approved these changes
Dec 30, 2019
mitchell852
left a comment
Member
There was a problem hiding this comment.
Looks like all the PR comments have been addressed and the behavior emulates that of the Perl endpoints. All unit tests and API tests pass as well as well as a manual test in TP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This is a rewrite of the perl endpoints GET,POST for /federations/{id}/federation_resolvers
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the added API test against both the Perl and Go backends.
You can also test this in TP by adding federation resolvers to federations and ensuring that they show up in the UI.
The following criteria are ALL met by this PR