Fix using http2 between TO and TM when setting proxy#3927
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
is there not a good way to do this globally? i'm just worried that other PRs will sneak thru without this type of change applied and generate a lot of bugs. i.e. #2305 |
|
Agreed with you @mitchell852. One question is what services besides TM/TR does the TO talk to? If we put getting http clients for each of them into a common method we can enforce it a little better as https://github.com/apache/trafficcontrol/pull/2305/files#diff-6e647a5b8d470f399423ff712efb0050R40 does. As we talked we can set it globally per https://golang.org/src/net/http/doc.go via |
|
It talks to TV and TS and a mail server (sort of and sometimes) |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
ocket8888
left a comment
There was a problem hiding this comment.
Compiles, works, fixes the issue.
|
Refer to this link for build results (access rights to CI server needed): |
What does this PR (Pull Request) do?
If TM has an https proxy set that is used by TO to connect it will fail as golang uses http2 be default in that case. This PR overrides that behavior based on the net godocs https://golang.org/src/net/http/doc.go.
There is not documentation changes as it is a bug fix and there is no tests as we dont have TM set up for our API tests
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Setup TM proxy with HTTPs ensure endpoint cdns/capacity work
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR