Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add deprecated message to cachegroup/:parameter_id/parameter resp #3908

Closed
mhoppa wants to merge 1 commit into from
Closed

Add deprecated message to cachegroup/:parameter_id/parameter resp #3908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion traffic_ops/app/lib/API/Cachegroup.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ sub by_parameter_id {
}
}

$self->success( { cachegroups => \@data } );
$self->success( { cachegroups => \@data }, "API path is deprecated use /cachegroupparameters instead");

@ocket8888 ocket8888 Oct 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Success" is a bit of a weird type of message for something that's more of a warning about a deprecation. This should use the "warning" level instead, imo.

@mitchell852 mitchell852 Nov 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the alert "levels"? success, error, warning and info?

@mitchell852 mitchell852 Nov 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought you could return an array of alerts. if so, what about 1 success message (for the successful assignment of a param to a cg) and 1 warning message with the deprecation message? or is that weird?

@mhoppa mhoppa Nov 7, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think that is what we want to do! THat would match the work that was done #3954

}

sub available_for_parameter {
Expand Down