Add TO Go cachegroups/id/deliveryservices#2300
Conversation
rob05c
added
new feature
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
This method conflicts with the method here: https://github.com/apache/trafficcontrol/blob/master/traffic_ops/client/v13/deliveryserviceserver.go#L26
There was a problem hiding this comment.
This method conflicts with the method here: https://github.com/apache/trafficcontrol/blob/master/traffic_ops/client/v13/deliveryserviceserver.go#L59
There was a problem hiding this comment.
Fixed. I left these, and removed the others, because these return more data.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Rebased, API tests pass, unit tests pass. |
|
Refer to this link for build results (access rights to CI server needed): |
| } | ||
|
|
||
| // FinishTx commits the transaction if commit is true when it's called, otherwise it rolls back the transaction. This is designed to be called in a defer. | ||
| func FinishTx(tx *sql.Tx, commit *bool) { |
There was a problem hiding this comment.
Is this something that needs to be implemented on all Handlers now?
There was a problem hiding this comment.
No, this was a legacy thing, because this PR was made before everything was changed to use transactions. I removed it.
|
Refer to this link for build results (access rights to CI server needed): |
5 participants
What does this PR do?
Add TO Go cachegroups/id/deliveryservices
Which TC components are affected by this PR?
What is the best way to verify this PR?
POST /api/1.2/cachegroups/id/deliveryservices/Check all that apply