Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add TO Go caches/stats endpoint#2278

Merged
mitchell852 merged 2 commits into
apache:masterfrom
rob05c:to-go-caches-stats
Feb 5, 2019
Merged

Add TO Go caches/stats endpoint#2278
mitchell852 merged 2 commits into
apache:masterfrom
rob05c:to-go-caches-stats

Conversation

@rob05c

@rob05c rob05c commented May 15, 2018

Copy link
Copy Markdown
Member

This endpoint queries the Traffic Monitor; the "API Test" framework doesn't currently support endpoints that hit the Monitor.

@asfgit

asfgit commented May 16, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1580/
Test PASSed.

@rob05c
rob05c force-pushed the to-go-caches-stats branch from 3092455 to 1d33436 Compare May 18, 2018 19:06
@asfgit

asfgit commented May 18, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1613/
Test PASSed.

@rob05c
rob05c force-pushed the to-go-caches-stats branch from 1d33436 to d2d3309 Compare May 22, 2018 14:51
@asfgit

asfgit commented May 22, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1638/
Test PASSed.

@rob05c
rob05c force-pushed the to-go-caches-stats branch from d2d3309 to 1a292ce Compare June 25, 2018 17:04
@asfgit

asfgit commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1906/
Test PASSed.

@rob05c
rob05c force-pushed the to-go-caches-stats branch from 1a292ce to fe64f64 Compare July 9, 2018 16:44
@asfgit

asfgit commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2038/
Test PASSed.

@rob05c
rob05c force-pushed the to-go-caches-stats branch 2 times, most recently from b840ce8 to 864a1d1 Compare August 6, 2018 16:51
@asfgit

asfgit commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2190/
Test PASSed.

@rob05c
rob05c force-pushed the to-go-caches-stats branch 2 times, most recently from 067edcc to 22df4a4 Compare January 22, 2019 23:37
@asfgit

asfgit commented Jan 22, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3085/
Test PASSed.

@asfgit

asfgit commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3086/
Test PASSed.

Previously, the endpoint returned an error if the first monitor it
tried failed. This changes it to retry all online monitors.
@rob05c
rob05c force-pushed the to-go-caches-stats branch from 22df4a4 to 544906c Compare January 30, 2019 23:29
@asfgit

asfgit commented Jan 30, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3138/
Test PASSed.

@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Feb 5, 2019
@mitchell852

Copy link
Copy Markdown
Member

@ocket8888 is going to review this PR

{1.1, http.MethodPost, `asns/?$`, api.CreateHandler(asn.GetTypeSingleton()), auth.PrivLevelOperations, Authenticated, nil},
{1.1, http.MethodDelete, `asns/{id}$`, api.DeleteHandler(asn.GetTypeSingleton()), auth.PrivLevelOperations, Authenticated, nil},

{1.1, http.MethodGet, `caches/stats/?(\.json)?$`, cachesstats.Get, auth.PrivLevelReadOnly, Authenticated, nil},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is unique to this endpoint, but this will allow me to GET /api/1.x/caches/stats/.json. I checked and it seems that the Perl allows this, so maybe for that reason alone we don't want to change it, but it's weird.

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly like the Perl endpoint from what I can see.

@mitchell852
mitchell852 merged commit 6eac9c6 into apache:master Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants