fix(frontend): remove the Execution Settings hover popover next to the Run button#5118
Open
chenlica wants to merge 1 commit into
Open
fix(frontend): remove the Execution Settings hover popover next to the Run button#5118chenlica wants to merge 1 commit into
chenlica wants to merge 1 commit into
Conversation
The "Execution Settings" hover popover next to the Run button — with an execution-name input and an email-notification toggle — was unnecessary UX clutter. The runWorkflow() handler already falls back to "Untitled Execution" when no explicit name is provided, so removing the popover leaves the Run button's behavior unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
============================================
+ Coverage 43.17% 43.18% +0.01%
Complexity 2208 2208
============================================
Files 1045 1045
Lines 40254 40244 -10
Branches 4250 4250
============================================
Hits 17378 17378
+ Misses 21804 21794 -10
Partials 1072 1072
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Remove the "Execution Settings" hover popover that appears next to the Run button in the workflow editor. The popover contained a custom-execution-name input and an email-notification toggle, but the same defaults work for ~all users and the hover trigger was felt to be unnecessary UX clutter.
nz-popoverdirectives and the<ng-template #executionSettings>block frommenu.component.html.runWorkflow()handler already falls back to"Untitled Execution"whencurrentExecutionNameis empty, so behavior on click is unchanged.currentExecutionName(still declared as an unused@Input) and the email-notification toggle config flag remain in place for now; cleaning them up can be a follow-up if there's interest.Any related issues, documentation, discussions?
No linked issue — small UX cleanup.
How was this PR tested?
Verified locally by applying the same edit to a running
ng servedev server: the hot-reloaded bundle no longer contains the"Execution Settings"string, and the Run button still triggersrunWorkflow()with the default"Untitled Execution"name on click.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)