fix(frontend): remove stray ']="true"' in user-dataset search input#5072
Merged
aglinxinyuan merged 1 commit intoMay 15, 2026
Merged
Conversation
The standalone-conversion codemod from apache#4873 (commit 3dd556a) partially stripped an Angular property binding off the <nz-select> in user-dataset.component.html, leaving a bare `]="true"` with no opening `[`. The browser throws `InvalidCharacterError: Invalid qualified name: ']'` when initializing UserDatasetComponent, which blocks rendering of both the Datasets and Workflows dashboard routes (both pull in the same template chunk). Delete the orphan line — surrounding bindings render fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
=========================================
Coverage 43.05% 43.05%
Complexity 2207 2207
=========================================
Files 1045 1045
Lines 40216 40216
Branches 4243 4243
=========================================
Hits 17313 17313
Misses 21832 21832
Partials 1071 1071
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aglinxinyuan
approved these changes
May 15, 2026
Contributor
|
Late LGTM! But in the future please file an issue for fixes as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Delete a stray
]="true"line infrontend/src/app/dashboard/component/user/user-dataset/user-dataset.component.html.Root cause. The standalone-conversion codemod from #4873 (commit
3dd556a) partially stripped an Angular property binding off the<nz-select>in this template, leaving a bare]="true"with no matching[<attribute>opening.Symptom. During
UserDatasetComponentinitialization Angular callselement.setAttribute(']', 'true'), which the browser rejects with:This blocks rendering of both
/dashboard/user/datasetand/dashboard/user/workflow(both routes load the same template chunk), so users hit a blank page after login.Fix. Delete the orphan line. Surrounding
[nzOpen],[(ngModel)],[nzAllowClear]bindings render fine on their own.Before / after diff
nzVariant="borderless" - ]="true" [nzOpen]="false" ngDefaultControl [(ngModel)]="filters.masterFilterList" [nzAllowClear]="true">Any related issues, documentation, discussions?
3dd556a(PR #4873 — "refactor(frontend): convert all components to standalone").How was this PR tested?
Formatting (per
CONTRIBUTING.md"yarn format:fix"). Ran the project's prettier-eslint pipeline against the changed file:→ exit 0, no diff. The file already conforms to the project format.
Production build.
yarn build(≡ng build --configuration=production) → exit 0.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
The bug was diagnosed with assistance from Claude Code (Anthropic Claude Opus 4.7), which read the FileService server-side stack trace and Safari console error, traced the regression to commit
3dd556aviagit blame, and authored this PR description. The one-line code change was reviewed and verified manually.