Skip to content

fix(frontend): remove stray ']="true"' in user-dataset search input#5072

Merged
aglinxinyuan merged 1 commit into
apache:mainfrom
eugenegujing:fix/frontend-user-dataset-stray-bracket
May 15, 2026
Merged

fix(frontend): remove stray ']="true"' in user-dataset search input#5072
aglinxinyuan merged 1 commit into
apache:mainfrom
eugenegujing:fix/frontend-user-dataset-stray-bracket

Conversation

@eugenegujing
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Delete a stray ]="true" line in frontend/src/app/dashboard/component/user/user-dataset/user-dataset.component.html.

Root cause. The standalone-conversion codemod from #4873 (commit 3dd556a) partially stripped an Angular property binding off the <nz-select> in this template, leaving a bare ]="true" with no matching [<attribute> opening.

Symptom. During UserDatasetComponent initialization Angular calls element.setAttribute(']', 'true'), which the browser rejects with:

InvalidCharacterError: Invalid qualified name: ']'
    at setAttribute (_dom_renderer-chunk.mjs:587)
    at UserDatasetComponent_Template — user-dataset.component.html:41

This blocks rendering of both /dashboard/user/dataset and /dashboard/user/workflow (both routes load the same template chunk), so users hit a blank page after login.

Fix. Delete the orphan line. Surrounding [nzOpen], [(ngModel)], [nzAllowClear] bindings render fine on their own.

Before / after diff

       nzVariant="borderless"
-      ]="true"
       [nzOpen]="false"
       ngDefaultControl
       [(ngModel)]="filters.masterFilterList"
       [nzAllowClear]="true">

Any related issues, documentation, discussions?

  • Regression introduced by commit 3dd556a (PR #4873 — "refactor(frontend): convert all components to standalone").
  • No tracking issue was filed — the fix is one line and the root cause is mechanical (codemod off-by-one).

How was this PR tested?

  1. Formatting (per CONTRIBUTING.md "yarn format:fix"). Ran the project's prettier-eslint pipeline against the changed file:

    yarn prettier-eslint --list-different \
      src/app/dashboard/component/user/user-dataset/user-dataset.component.html
    

    → exit 0, no diff. The file already conforms to the project format.

  2. Production build. yarn build (≡ ng build --configuration=production) → exit 0.


Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 4.7

The bug was diagnosed with assistance from Claude Code (Anthropic Claude Opus 4.7), which read the FileService server-side stack trace and Safari console error, traced the regression to commit 3dd556a via git blame, and authored this PR description. The one-line code change was reviewed and verified manually.

The standalone-conversion codemod from apache#4873 (commit 3dd556a) partially
stripped an Angular property binding off the <nz-select> in
user-dataset.component.html, leaving a bare `]="true"` with no opening `[`.
The browser throws `InvalidCharacterError: Invalid qualified name: ']'`
when initializing UserDatasetComponent, which blocks rendering of both
the Datasets and Workflows dashboard routes (both pull in the same
template chunk). Delete the orphan line — surrounding bindings render
fine.
@github-actions github-actions Bot added fix frontend Changes related to the frontend GUI labels May 15, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.05%. Comparing base (9ba490e) to head (62a0983).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5072   +/-   ##
=========================================
  Coverage     43.05%   43.05%           
  Complexity     2207     2207           
=========================================
  Files          1045     1045           
  Lines         40216    40216           
  Branches       4243     4243           
=========================================
  Hits          17313    17313           
  Misses        21832    21832           
  Partials       1071     1071           
Flag Coverage Δ *Carryforward flag
access-control-service 39.53% <ø> (ø) Carriedforward from 9ba490e
agent-service 33.72% <ø> (ø) Carriedforward from 9ba490e
amber 43.77% <ø> (ø) Carriedforward from 9ba490e
computing-unit-managing-service 0.00% <ø> (ø) Carriedforward from 9ba490e
config-service 0.00% <ø> (ø) Carriedforward from 9ba490e
file-service 32.18% <ø> (ø) Carriedforward from 9ba490e
frontend 33.93% <ø> (ø)
python 90.37% <ø> (ø) Carriedforward from 9ba490e
workflow-compiling-service 47.72% <ø> (ø) Carriedforward from 9ba490e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aglinxinyuan aglinxinyuan merged commit 1ea368d into apache:main May 15, 2026
17 checks passed
@Yicong-Huang
Copy link
Copy Markdown
Contributor

Late LGTM! But in the future please file an issue for fixes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants