test(amber): ignore failing source-propagation reconfiguration case#4546
Merged
Yicong-Huang merged 1 commit intoApr 28, 2026
Conversation
The Python source -> Python UDF reconfiguration test in ReconfigurationSpec hangs after the UDF processes the EndChannel ECM, causing a 1-minute Await timeout. Other reconfiguration cases (single-op, CSV-source, two-UDF chain) still pass. Ignored to unblock CI; restore once the source-propagation completion path is fixed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Yicong-Huang
added a commit
that referenced
this pull request
Apr 28, 2026
### What changes were proposed in this PR? This PR fixes the Python reconfiguration hang reported in #4545 and explicitly re-enables the regression test that was temporarily ignored in #4546. The regression came from `#4424` (`ef66190f22`), which changed the lifetime of Python `current_internal_marker`. After that change, `get_internal_marker()` stopped consuming the marker on read, and the main loop deferred cleanup until after replaying internal channel markers. For Python source operators, that allowed an internal `EndChannel` marker to remain visible across the pause and reconfiguration window. When the reconfiguration ECM was processed, the stale marker could be observed and replayed again, which corrupted end-of-stream handling and caused the workflow to hang. This PR restores the expected one-time consumption behavior by: - making `get_internal_marker()` consume `current_internal_marker` when it is read - removing the extra delayed cleanup after replaying internal channel markers in the Python main loop - changing `should propagate reconfiguration through a source operator in workflow` in `ReconfigurationSpec` from `ignore` back to a normal enabled test ### Any related issues, documentation, discussions? Fixes #4545. Regression introduced by #4424. Re-enables the temporary test disable from #4546 after fixing the underlying lifecycle bug. ### How was this PR tested? Tested with existing Scala tests using Java 11: - `WorkflowExecutionService/testOnly org.apache.texera.amber.engine.e2e.ReconfigurationSpec` This run included the re-enabled `should propagate reconfiguration through a source operator in workflow` case. The full `ReconfigurationSpec` passed on the rebased branch (`5/5` passed, `0` ignored). ### Was this PR authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Marks
ReconfigurationSpec's"Engine should propagate reconfiguration through a source operator in workflow"case asignoreto unblock CI. The test consistently hangs at the 1-minuteAwaitbecause the UDF stops making progress after processing theEndChannelECM in the multi-worker (Python source -> Python UDF) propagation path.The other four cases in the spec (single-op python UDF reconfigure, java operator reconfigure, source-as-target rejection, two-UDF chain) still run and pass.
A code comment is left at the test pointing at the symptom and the condition for re-enabling.
Any related issues, documentation, discussions?
Put out the fire in #4545. Investigation is in parallel.
Follow-up to #4220 (which added the test) and #4531 (which restored the web-service entrypoint but did not fix this hang).
How was this PR tested?
sbt "WorkflowExecutionService/testOnly *ReconfigurationSpec"locally — 4 cases pass, the 5th is now skipped (was previously timing out at 1 min).Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)