chore(amber): remove typing and dataclasses backport packages#4523
Merged
Yicong-Huang merged 3 commits intoApr 26, 2026
Merged
Conversation
`typing==3.7.4.3` is a backport of the `typing` stdlib module for Python <3.5; `dataclasses==0.6` is a backport for Python <3.7. This repo's CI matrix is 3.10–3.13, so both are obsolete. Installing them is wasted CI time, and the PyPI `typing` package can shadow the stdlib version in subtle ways because its API is frozen at 3.7-era. Side benefit: on Python 3.13, `typing==3.7.4.3` has no prebuilt wheel and is built from source on every CI run. Closes apache#4522 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
engine
dependencies
Yicong-Huang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes two PyPI backport packages from
amber/requirements.txt:typing==3.7.4.3— backport of thetypingstdlib module for Python <3.5. Has been part of the stdlib since 3.5.dataclasses==0.6— backport of thedataclassesstdlib module for Python <3.7. Has been part of the stdlib since 3.7.This repo's CI matrix is Python 3.10–3.13, so both are obsolete. Installing them on supported versions is wasted CI time, and the PyPI
typingpackage can shadow the stdlib version in subtle ways because its API is frozen at 3.7-era.typing_extensions==4.14.1(line 34, kept) is a different, still-maintained package that backports new typing features to older Pythons; it's correctly retained.Any related issues, documentation, discussions?
Closes #4522. Surfaced during investigation in #4519/#4521.
How was this PR tested?
CI
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)