Skip to content

generate proto file#1620

Merged
j143 merged 5 commits intoapache:mainfrom
j143:proto-upgrade
May 22, 2022
Merged

generate proto file#1620
j143 merged 5 commits intoapache:mainfrom
j143:proto-upgrade

Conversation

@j143
Copy link
Member

@j143 j143 commented May 21, 2022

discussion points:

  1. the generated java file is not taking the license header
  2. Content seems to be a bit different from the older version of generated java file. (is there a way to test it)
  3. Is this generation step going to happen every time we run mvn package

Solves #1578

@j143 j143 requested a review from Baunsgaard May 21, 2022 13:56
@Baunsgaard
Copy link
Contributor

overall i think this seems nice.
We can just add that license is not needed in this file.

@j143 j143 merged commit 264de9b into apache:main May 22, 2022
@j143 j143 deleted the proto-upgrade branch May 22, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants