Skip to content

keep release scripts concise #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j143 merged 1 commit into from
Apr 15, 2022
Merged

keep release scripts concise #1549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions dev/release/create-tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,7 @@ printf "$NEXT_VERSION"
# options available at https://maven.apache.org/plugins/maven-gpg-plugin/sign-mojo.html
GPG_OPTS="-Dgpg.homedir=$GNUPGHOME -Dgpg.keyname=$GPG_KEY -Dgpg.passphrase=$GPG_PASSPHRASE"

printf "\n -Dgpg.homedir=$GNUPGHOME -Dgpg.keyname=$GPG_KEY -Dgpg.passphrase=$GPG_PASSPHRASE \n"

# Tag release version before `mvn release:prepare`
# tag python build
# PySpark version info we use dev0 instead of SNAPSHOT to be closer
# to PEP440.
# sed -i".tmp" 's/__version__ = .*$/__version__ = "'"$NEXT_VERSION.dev0"'"/' python/systemds/version.py

# change tags in docs
# docs/_config.yml
# update SYSTEMDS_VERSION
# sed -i 's/SYSTEMDS_VERSION:.*$/SYSTEMDS_VERSION: '"$RELEASE_VERSION"'/g' docs/_config.yml
# and run docs/updateAPI.sh to update version in api docs
printf "\n -Dgpg.homedir=$GNUPGHOME -Dgpg.keyname=$GPG_KEY \n"


# NOTE:
Expand Down Expand Up @@ -130,9 +118,3 @@ printf "\n #### Executing command: #### \n"
printf "\n $(bold $(greencolor $CMD)) \n\n"

$CMD

# tag snapshot version after `mvn release:prepare`

# Change docs to dev snapshot tag
# sed -i".tmp1" 's/SYSTEMDS_VERSION:.*$/SYSTEMDS_VERSION: '"$NEXT_VERSION"'/g' docs/_config.yml
# and run docs/updateAPI.sh to update version in api docs
35 changes: 0 additions & 35 deletions dev/release/release-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,41 +97,6 @@ cat <<EOF >../tmp-settings.xml
</settings>
EOF

if [[ "$1" == "publish-snapshot" ]]; then

CMD="mvn --settings ../tmp-settings.xml deploy -DskipTests -Dmaven.deploy.skip=${dry_run} \
-Daether.checksums.algorithms=SHA-512 \
${GPG_OPTS}"
# -DaltSnapshotDeploymentRepository=github::default::https://maven.pkg.github.com/j143/systemds \
printf "\n #### Executing command: #### \n"
printf "\n $(bold $(greencolor $CMD)) \n\n"

$CMD

fi



if [[ "$1" == "publish-staging" ]]; then

mvn versions:set -DnewVersion=${PACKAGE_VERSION}

CMD="mvn --settings ../tmp-settings.xml clean -Pdistribution deploy \
-DskiptTests -Dmaven.deploy.skip=${dry_run} \
-Daether.checksums.algorithms=SHA-512 \
${GPG_OPTS}"

printf "\n #### Executing command: #### \n"
printf "\n $(bold $(greencolor $CMD)) \n\n"

$CMD
fi

# if [[ -z "$GPG_KEY" ]]; then
# echo "The environment variable $GPG_KEY is not set."
# fi

# GPG="gpg -u $GPG_KEY --no-tty --batch --pinentry-mode loopback"

# Publishing to Sonatype repo, details:
NEXUS_ROOT=https://repository.apache.org/service/local/staging
Expand Down