Action for building docker images automatically#1441
Conversation
|
I think we can split the images a bit and reduce builds.
Thanks for the help! |
.github/workflows/docker-pub.yml
Outdated
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up QEMU |
There was a problem hiding this comment.
It is an add-on, incase we want to build multi arch images. Optional though!
https://github.com/docker/buildx/#building-multi-platform-images
usage
$ docker buildx build --platform linux/amd64,linux/arm64 .I do not have a about whether we need this. Perhaps, federated feature
might need this (I do not have good understanding yet).
There was a problem hiding this comment.
hmm, then for now lets not include it if it is not needed
docker/sysds.Dockerfile
Outdated
| rm -r target/maven-archiver && \ | ||
| rm -r target/systemds-** && \ | ||
| rm -r docker && \ | ||
| # rm -r docker && \ |
There was a problem hiding this comment.
you cannot just comment out a line in this multi-line instruction, then everything after it does not execute.
There was a problem hiding this comment.
| # rm -r docker && \ | |
| rm -r docker && \ |
There was a problem hiding this comment.
Not sure what you mean?
just for information the reason why i have this line is to remove the docker folder from the internal copied systemds repository, it does not make a difference for the building of the docker image except it makes the end result slightly smaller.
so therefore, don't out comment it :)
docker/sysds.Dockerfile
Outdated
| COPY docker/mountFolder/main.dml /input/main.dml | ||
| RUN mkdir /input && echo 'print("Hello from SystemDS")' > /input/main.dml | ||
|
|
||
| # COPY docker/mountFolder/main.dml /input/main.dml |
There was a problem hiding this comment.
i'm all for running it but don't remove the copy, so that the only change you make it to add the RUN line.
There was a problem hiding this comment.
I am having error with running COPY
There was a problem hiding this comment.
this is happening because of your out commented line mentioned above.
There was a problem hiding this comment.
this one:
# rm -r docker && \
|
I think it is fine if we just add the on commit part of the docker for now, |
|
@j143 |
There are already secrets available. the problem seems to be |

Tasks
How to Review?
Published artifact at https://hub.docker.com/r/return01/test-ghactions-systemds
Usage test:
Secrets:
DOCKERHUB_USERandDOCKERHUB_TOKENThese two variables are already set by INFRA. No need to set from our end.
https://issues.apache.org/jira/browse/INFRA-22430