feat(build): migrate from Prettier to Oxfmt for performant code formatting - #42434
Merged
Conversation
…tting Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
requested review from
eschutho,
geido,
mistercrunch,
rusackas,
sadpandajoe and
villebro
as code owners
July 26, 2026 08:14
Contributor
Code Review Agent Run #c73f95Actionable Suggestions - 0Additional Suggestions - 1
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #42434 +/- ##
=======================================
Coverage 65.43% 65.43%
=======================================
Files 2810 2810
Lines 159528 159537 +9
Branches 36410 36419 +9
=======================================
+ Hits 104380 104387 +7
- Misses 53102 53104 +2
Partials 2046 2046
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: hainenber <dotronghai96@gmail.com>
sadpandajoe
approved these changes
Jul 28, 2026
hainenber
requested review from
betodealmeida,
dpgaspar,
kgabryje,
nytai and
sha174n
as code owners
August 2, 2026 10:33
github-actions
Bot
added
the
github_actions
Signed-off-by: hainenber <dotronghai96@gmail.com>
This was due to Oxfmt escaping the MDX/JSX comment syntax with literal backlash, failing MDX loader used by @Docusaurus Signed-off-by: hainenber <dotronghai96@gmail.com>
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
rusackas
approved these changes
Aug 3, 2026
Contributor
|
Bito Automatic Review Skipped – PR Already Merged |
9 tasks
mikebridge
added a commit
to mikebridge/superset
that referenced
this pull request
Aug 3, 2026
…ame type Post-rebase housekeeping for two things that landed on master: - apache#42434 migrated the repo from Prettier to Oxfmt. Only three of this branch's files needed reformatting (the rest are new files Oxfmt had never seen); the changes are wrapping-only. - apache#42711 removed `username` from the version payload's `changed_by`, so `VersionChangedBy` — which existed solely to add that field to `ActivityChangedBy` and had no other consumer — is deleted. `VersionMeta` now uses `ActivityChangedBy` directly, which is what the server-side schema-parity test enforces. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(build): migrate from Prettier to Oxfmt for performant code formatting
SUMMARY
30x faster than Prettier, which is translated to 1 second formatting whole Superset codebase compared to Prettier's 30s!
There'll be more codes added to the project and switching to a more performant formatter is, IMO, future-proofing.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI
ADDITIONAL INFORMATION