chore(viz)!: rebuild Nightingale Rose on ECharts, removing nvd3 entirely - #42381
Merged
Conversation
dosubot
Bot
added
change:frontend
Contributor
|
Bito Automatic Review Skipped - Branch Excluded |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove-legacy-viz-pipeline #42381 +/- ##
==============================================================
+ Coverage 65.13% 65.25% +0.11%
==============================================================
Files 2807 2806 -1
Lines 156070 155887 -183
Branches 35846 35820 -26
==============================================================
+ Hits 101661 101718 +57
+ Misses 52510 52270 -240
Partials 1899 1899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rusackas
added
the
🎪 ⚡ showtime-trigger-start
github-actions
Bot
added
🎪 27b9582 🚦 building
🎪 ⌛ 48h
Contributor
Contributor
|
🎪 Showtime deployed environment on GHA for 27b9582 • Environment: http://35.161.124.153:8080 (admin/admin) |
rusackas
requested review from
betodealmeida,
dpgaspar,
eschutho,
hainenber,
kgabryje,
michael-s-molina,
mistercrunch,
nytai and
sha174n
as code owners
July 27, 2026 22:42
…entirely Replaces the d3/nvd3-fork rose renderer with an ECharts implementation: stacked bar series on polar coordinates reproduce the per-period sectors with radially stacked groups, in both radius- and area-proportional modes (area mode plots sqrt-normalized increments on a unit radius axis so wedge area encodes the value, matching the legacy proportion math). Rich and plain tooltips, the time-period axis labels, legend toggling and the theme-aware text all come along, and the legacy click-to-expand interaction survives as a drill: clicking a sector morphs that period into a full pie via universalTransition, and clicking again returns. Control names, buildQuery and the transformData reshape (with its tests) carry over unchanged, so saved charts keep working with no migration. The plugin-chart-rose package is deleted, which removes the last consumer of nvd3-fork: nvd3 is now entirely out of the dependency tree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tives Difference-style comparisons can drive the running total negative, which turned the area-mode sqrt into a NaN radius. Clamp the radicand at 0 so a negative cumulative collapses to the center instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The transform sorted period keys with parseInt and then re-looked-up datum by the parsed number, which silently dropped every period when __timestamp was serialized as anything other than a plain epoch number (an ISO string, for instance), leaving a blank chart. Sort numerically where possible but index by the original key, and carry each period's raw timestamp on its entries for the axis label. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rusackas
added
🎪 ⚡ showtime-trigger-start
github-actions
Bot
added
🎪 77d20d4 🚦 building
🎪 ⌛ 48h
Contributor
Contributor
|
🎪 Showtime deployed environment on GHA for 77d20d4 • Environment: http://35.163.161.155:8080 (admin/admin) |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rebuilds the Nightingale Rose chart on ECharts and deletes
plugin-chart-rose, removing the last consumer ofnvd3-fork— nvd3 is now entirely out of the dependency tree.The new renderer uses stacked bar series on polar coordinates: one angular sector per time period with the group series stacked radially, in both radius- and area-proportional modes (area mode plots sqrt-normalized increments on a unit radius axis, matching the legacy proportion math where wedge area encodes the value). Rich/plain tooltips, period axis labels, legend toggling and dark-theme text all carry over. The legacy click-to-expand interaction survives as a drill: clicking a sector morphs that period into a full pie of its series (via ECharts
universalTransition), and clicking a slice returns to the rose. Slice colors stay consistent between the two views.Control names,
viz_type,buildQueryand thetransformDatareshape (with its tests) are unchanged, so saved charts keep working with no migration. Thumbnails recaptured from the new renderer.Not carried over: the exact d3 tween choreography of the old expand animation (the shrink-to-mini-rose backdrop); the morph animation replaces it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Rose view and the drilled period pie render as in the refreshed thumbnails; the drill round-trip was verified interactively in light and dark themes.
TESTING INSTRUCTIONS
npx jest plugins/plugin-chart-echarts/test/Rose(18 tests).grep -c nvd3 superset-frontend/package-lock.jsonreturns 0.ADDITIONAL INFORMATION
🤖 Generated with Claude Code