feat(compare): migrate compare charts to echarts_timeseries_line and drop the legacy plugin - #41738
Merged
Merged
Conversation
rusackas
requested review from
betodealmeida,
eschutho,
michael-s-molina,
mistercrunch and
sadpandajoe
as code owners
July 3, 2026 07:37
Contributor
|
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR). |
…drop the legacy plugin Adds a MigrateCompareChart processor (the shared TimeseriesChart base already handles the timeseries control mapping, including normalizing the legacy 'absolute' comparison type), registers it with the viz migration CLI, and adds the Alembic revision with the standard MySQL MEDIUMTEXT widening and reversible form_data backups. The nvd3 Compare plugin, its registrations, the NVD3CompareTimeSeriesViz backend class and the cumulative-line renderer branch are removed. The nvd3 renderer's interactive re-basing (clicking a point to re-base percentages) is not preserved by the ECharts line chart; noted for UPDATING.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rusackas
force-pushed
the
legacy-viz-t3-compare
branch
from
July 3, 2026 07:38
3ab32c2 to
35d9d50
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove-legacy-viz-pipeline #41738 +/- ##
=============================================================
Coverage ? 64.77%
=============================================================
Files ? 2702
Lines ? 149087
Branches ? 34475
=============================================================
Hits ? 96574
Misses ? 50753
Partials ? 1760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
9 tasks
rusackas
added a commit
that referenced
this pull request
Jul 7, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 7, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 8, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 10, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 13, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 14, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 15, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 15, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 16, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 17, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 20, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 20, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 20, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 21, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 21, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 23, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 27, 2026
…drop the legacy plugin (#41738) Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tier 3 of #41714 (targets
remove-legacy-viz-pipeline): retire the nvd3 Time-series Percent Change (compare) chart by migrating saved charts to the ECharts Line Chart (echarts_timeseries_line).MigrateCompareChartprocessor — the sharedTimeseriesChartbase already handles the whole nvd3 timeseries control mapping (including normalizing the legacyabsolutecomparison type), so the subclass only declares the source/target viz types. Registered with thesuperset viz-migrationsCLI and covered by a unit test.e5f6a7b8c9d0(chained after the bubble migration) with the standard MySQL MEDIUMTEXT widening and reversibleform_data_bakbackups.NVD3CompareTimeSeriesVizbackend class, and the cumulative-line branch of the shared NVD3 renderer.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Saved Percent Change charts re-open as ECharts Line Charts.
TESTING INSTRUCTIONS
pytest tests/unit_tests/migrations/viz/nvd3_compare_chart_to_echarts_test.pypasses.npm run test -- plugins/legacy-preset-chart-nvd3passes.superset db upgradethen open a formerly-comparechart — renders as an ECharts line chart;superset db downgraderestores the original form_data.ADDITIONAL INFORMATION
compareslices; no downtime expected🤖 Generated with Claude Code